[asterisk-dev] [Code Review] Modify bridging to properly evaluate DTMF after first warning is played

[Jeff Peeler]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.digium.com/r/163/
-----------------------------------------------------------

Review request for Asterisk Developers.


Summary
-------

The main problem is currently if the Dial flag L is used with a warning sound, DTMF is not evaluated after the first warning sound.

These changes are actually pretty simple in retrospect. ast_generic_bridge has been modified to:
- return AST_BRIDGE_COMPLETE when DTMF is detected so that possible feature matches are evaluated in res_features
- set a flag for playing the warning which ensures that if a scheduled warning is missed multiple warnings are not played back to back (due to a feature evaluation or waiting for digits)

ast_channel_bridge was modified to store the nexteventts in the ast_bridge_config structure as that information was lost every time ast_channel_bridge was reentered, causing a hangup due to incorrect time calculations.


This addresses bug 14315.
    http://bugs.digium.com/view.php?id=14315


Diffs
-----

  /branches/1.4/include/asterisk/channel.h 176209 
  /branches/1.4/main/channel.c 176209 
  /branches/1.4/res/res_features.c 176209 

Diff: http://reviewboard.digium.com/r/163/diff


Testing
-------

Tested exact scenario pretty extensively. Also made sure normal bridging works as expected as well as a time limited bridge with no warning.


Thanks,

Jeff