[asterisk-dev] [Code Review] inotify support for checking timezone file modification

[Mark Michelson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.digium.com/r/136/#review421
-----------------------------------------------------------



/trunk/main/stdtime/localtime.c
<http://reviewboard.digium.com/r/136/#comment1003>

    If inotify_fd does not have O_NONBLOCK set, I don't see how errno could get set to EAGAIN. I guess it doesn't hurt to check for it though.



/trunk/main/stdtime/localtime.c
<http://reviewboard.digium.com/r/136/#comment1004>

    Why poll and not something like nanosleep?



/trunk/main/stdtime/localtime.c
<http://reviewboard.digium.com/r/136/#comment1001>

    Check for error here



/trunk/main/stdtime/localtime.c
<http://reviewboard.digium.com/r/136/#comment997>

    Using poll seems like an odd choice. Why not, say, nanosleep?



/trunk/main/stdtime/localtime.c
<http://reviewboard.digium.com/r/136/#comment998>

    Check for errors in stat and lstat



/trunk/main/stdtime/localtime.c
<http://reviewboard.digium.com/r/136/#comment996>

    Be sure to check for errors in ast_pthread_create_background, stat, and lstat


- Mark


On 2009-02-03 12:07:37, Tilghman Lesher wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.digium.com/r/136/
> -----------------------------------------------------------
> 
> (Updated 2009-02-03 12:07:37)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Use the inotify(7) interface to delete cached timezone entries, when the underlying file changes.
> 
> 
> This addresses bug 14300.
>     http://bugs.digium.com/view.php?id=14300
> 
> 
> Diffs
> -----
> 
>   /trunk/configure 173130 
>   /trunk/configure.ac 173130 
>   /trunk/include/asterisk/autoconfig.h.in 173130 
>   /trunk/main/stdtime/localtime.c 173127 
> 
> Diff: http://reviewboard.digium.com/r/136/diff
> 
> 
> Testing
> -------
> 
> Compile-time only.
> 
> 
> Thanks,
> 
> Tilghman
> 
>