[asterisk-dev] [Code Review] Rework the Asterisk indications API

[Russell Bryant]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.digium.com/r/149/
-----------------------------------------------------------

(Updated 2009-02-13 16:32:50.958673)


Review request for Asterisk Developers.


Changes
-------

Updated patch with latest changes from Mark's review


Summary
-------

This patch includes a number of changes to the indications API.  The primary motivation for this work was to improve stability.  The object management in this API was significantly flawed, and a number of trivial situations could cause crashes.

The changes included are:

1) Remove the module res_indications.  This included the critical functionality that actually loaded the indications configuration.  I have seen many people have Asterisk problems because they accidentally did not have an indications.conf present and loaded.  In fact, this came up again in #asterisk-dev today.  Now, this code is in the core, and Asterisk will fail to start without indications configuration.  

There was one part of res_indications, the dialplan applications, which did belong in a module, and have been moved to a new module, app_playtones.

2) Object management has been significantly changed.  Tone zones are now managed using astobj2, and it is no longer possible to crash Asterisk by issuing a reload while tone zones are in use.

3) The API documentation has been filled out.

4) The API has been updated to follow our naming conventions.

5) Various bits of code throughout the tree have been updated to account for the API update.

6) Configuration parsing has been mostly re-written.

7) "Code cleanup"


Diffs (updated)
-----

  /trunk/apps/app_disa.c 175742 
  /trunk/apps/app_playtones.c PRE-CREATION 
  /trunk/apps/app_read.c 175742 
  /trunk/apps/app_readexten.c 175742 
  /trunk/channels/chan_misdn.c 175742 
  /trunk/channels/chan_skinny.c 175742 
  /trunk/channels/chan_unistim.c 175742 
  /trunk/configs/indications.conf.sample 175742 
  /trunk/funcs/func_channel.c 175742 
  /trunk/include/asterisk/_private.h 175742 
  /trunk/include/asterisk/channel.h 175742 
  /trunk/include/asterisk/indications.h 175742 
  /trunk/main/app.c 175742 
  /trunk/main/asterisk.c 175742 
  /trunk/main/channel.c 175742 
  /trunk/main/indications.c 175742 
  /trunk/main/loader.c 175742 
  /trunk/main/pbx.c 175742 
  /trunk/res/res_indications.c 175742 
  /trunk/res/snmp/agent.c 175742 

Diff: http://reviewboard.digium.com/r/149/diff


Testing
-------

Basic testing playing different tones using the Playtones() application works fine.


Thanks,

Russell