[asterisk-dev] [Code Review] inotify(7) support for pbx_spool

[Russell Bryant]

> On 2009-02-12 19:22:29, Mark Michelson wrote:
> > No need to attach the configure script on a review. configure.ac is sufficient.
> > 
> > This is a case where I'm placing a "Ship it!" on the code because it reads correctly. I'd feel a bit better about this if there were some actual testing done, however.
> > 
> > Good work, Tilghman!

Yes, I definitely think new functionality needs more than compile-only testing before being merged into trunk.


- Russell


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.digium.com/r/137/#review414
-----------------------------------------------------------


On 2009-02-12 19:06:24, Tilghman Lesher wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.digium.com/r/137/
> -----------------------------------------------------------
> 
> (Updated 2009-02-12 19:06:24)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Instead of scanning the directory and trying to keep tabs on the mtime of the directory, an approach which has already been shown to have an issue with directory entry races, use the kernel builtin method of inotify(7) to identify every file as it gets created in the spool directory.
> 
> 
> Diffs
> -----
> 
>   /trunk/configure 175312 
>   /trunk/configure.ac 175312 
>   /trunk/include/asterisk/autoconfig.h.in 175312 
>   /trunk/pbx/pbx_spool.c 175312 
> 
> Diff: http://reviewboard.digium.com/r/137/diff
> 
> 
> Testing
> -------
> 
> Compile-time testing only.
> 
> 
> Thanks,
> 
> Tilghman
> 
>