[asterisk-dev] [Code Review] inotify(7) support for pbx_spool

[Mark Michelson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.digium.com/r/137/#review409
-----------------------------------------------------------



/trunk/pbx/pbx_spool.c
<http://reviewboard.digium.com/r/137/#comment967>

    Check for failure here.



/trunk/pbx/pbx_spool.c
<http://reviewboard.digium.com/r/137/#comment965>

    As far as I can see, you never use this field of the buf struct.



/trunk/pbx/pbx_spool.c
<http://reviewboard.digium.com/r/137/#comment970>

    I'm not a fan of this block of code. I understand what's going on, but it feels like you're in a C golf competition with this. 
    
    (Just my opinion, feel free to ignore)


- Mark


On 2009-01-27 17:49:43, Tilghman Lesher wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.digium.com/r/137/
> -----------------------------------------------------------
> 
> (Updated 2009-01-27 17:49:43)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Instead of scanning the directory and trying to keep tabs on the mtime of the directory, an approach which has already been shown to have an issue with directory entry races, use the kernel builtin method of inotify(7) to identify every file as it gets created in the spool directory.
> 
> 
> Diffs
> -----
> 
>   /trunk/configure.ac 171187 
>   /trunk/pbx/pbx_spool.c 171187 
> 
> Diff: http://reviewboard.digium.com/r/137/diff
> 
> 
> Testing
> -------
> 
> Compile-time testing only.
> 
> 
> Thanks,
> 
> Tilghman
> 
>