[asterisk-dev] [Code Review] New queue CLI and Manager commands to facilitate fine-grained reloading

[Russell Bryant]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.digium.com/r/115/#review391
-----------------------------------------------------------


Post comments I have so far.  I'll continue on the new version of the diff that was just posted.



/trunk/apps/app_queue.c
<http://reviewboard.digium.com/r/115/#comment925>

    Unnecessary, since ast_calloc() logs the failure for you



/trunk/apps/app_queue.c
<http://reviewboard.digium.com/r/115/#comment929>

    It seems like an ao2_callback() would simplify this code a bit.



/trunk/apps/app_queue.c
<http://reviewboard.digium.com/r/115/#comment921>

    You have some issues with inconsistent indentation.



/trunk/apps/app_queue.c
<http://reviewboard.digium.com/r/115/#comment930>

    I think you could simplify this with an ao2_callback() as well



/trunk/apps/app_queue.c
<http://reviewboard.digium.com/r/115/#comment926>

    Should the queue be locked while you clear the stats?  Otherwise, you could get a report of the stats while you're in the middle of clearing them.



/trunk/apps/app_queue.c
<http://reviewboard.digium.com/r/115/#comment922>

    why not void?



/trunk/apps/app_queue.c
<http://reviewboard.digium.com/r/115/#comment923>

    struct ast_flags mask = { AST_FLAGS_ALL };



/trunk/apps/app_queue.c
<http://reviewboard.digium.com/r/115/#comment924>

    struct ast_flags mask = { AST_FLAGS_ALL };


- Russell


On 2009-02-11 14:19:50, Mark Michelson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.digium.com/r/115/
> -----------------------------------------------------------
> 
> (Updated 2009-02-11 14:19:50)
> 
> 
> Review request for Asterisk Developers and Jared Smith.
> 
> 
> Summary
> -------
> 
> The purpose of these changes is to add new CLI and manager commands in order to reload queues.
> 
> The new CLI commands are the "queue reload" and "queue reset stats" commands. The new manager commands
> are the QueueReload QueueReset commands. Rather than explain them in detail here, I'll direct you to the
> modified documentation in the code.
> 
> In order to easily facilitate these changes, I also revamped the backend functions. Now instead of having
> one giant function to reload queues, there are multiple small ones.
> 
> 
> Diffs
> -----
> 
>   /trunk/CHANGES 174883 
>   /trunk/apps/app_queue.c 174883 
> 
> Diff: http://reviewboard.digium.com/r/115/diff
> 
> 
> Testing
> -------
> 
> I ran many combinations of the CLI commands in succession, and a lesser number of the Manager commands. All appeared to do what is expected.
> 
> 
> Thanks,
> 
> Mark
> 
>