[asterisk-dev] [Code Review] Added Force Encrypt option to iax.conf

James Golovich james at gnuinter.net
Wed Feb 11 12:19:24 CST 2009


I've not used review board yet so I'll just send this to the list.  I
looked over the code and see a potential issue with the config processing.

If someones config specifieds forceencryption=yes then encryption=yes
afterwards the IAX_FORCE_ENCRYPT flag is cleared.

Also if/when there are other encryption methods supported, they probably
wont work with forceencryption since the value is checked for ast_true
and then get_encrypt_methods(v->value) is called.

So if someone has:

encryption=superencryptionalgo
forceencryption=yes

or even:
forceencryption=superencryptionalgo

it will revert to aes128 (in the first case) and the second case will
clear the IAX_FORCE_ENCRYPT flag

James



More information about the asterisk-dev mailing list