[asterisk-dev] [Code Review] New queue CLI and Manager commands to facilitate fine-grained reloading

[Olle E Johansson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.digium.com/r/115/#review385
-----------------------------------------------------------


I don't see any replies to the manager actions, but I could miss something. Please check how the manager reload works in other modules, like chan_sip, where we return some data on the changes or existing objects. I would guess that a queue reload could return the number of permanent members.

/O

- Olle E


On 2009-01-04 15:35:59, Mark Michelson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.digium.com/r/115/
> -----------------------------------------------------------
> 
> (Updated 2009-01-04 15:35:59)
> 
> 
> Review request for Asterisk Developers and Jared Smith.
> 
> 
> Summary
> -------
> 
> The purpose of these changes is to add new CLI and manager commands in order to reload queues.
> 
> The new CLI commands are the "queue reload" and "queue reset stats" commands. The new manager commands
> are the QueueReload QueueReset commands. Rather than explain them in detail here, I'll direct you to the
> modified documentation in the code.
> 
> In order to easily facilitate these changes, I also revamped the backend functions. Now instead of having
> one giant function to reload queues, there are multiple small ones.
> 
> 
> Diffs
> -----
> 
>   /trunk/CHANGES 167169 
>   /trunk/apps/app_queue.c 167169 
>   /trunk/main/ast_expr2.h 167169 
>   /trunk/main/ast_expr2.c 167169 
> 
> Diff: http://reviewboard.digium.com/r/115/diff
> 
> 
> Testing
> -------
> 
> I ran many combinations of the CLI commands in succession, and a lesser number of the Manager commands. All appeared to do what is expected.
> 
> 
> Thanks,
> 
> Mark
> 
>