[asterisk-dev] [Code Review] set ASTVARRUNDIR=$(localstatedir)/run/asterisk as default path

Matthew Nicholson mnicholson at digium.com
Wed Feb 11 09:13:43 CST 2009



> On 2009-02-11 09:11:32, Matthew Nicholson wrote:
> > trunk/contrib/scripts/safe_asterisk, lines 95-98
> > <http://reviewboard.digium.com/r/139/diff/1/?file=2507#file2507line95>
> >
> >     Perhaps this should be done at install time instead of here.

It looks like this is done at install time.  It seems redundant to have it here to.


- Matthew


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.digium.com/r/139/#review381
-----------------------------------------------------------


On 2009-02-02 15:57:37, Michiel van Baak wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.digium.com/r/139/
> -----------------------------------------------------------
> 
> (Updated 2009-02-02 15:57:37)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> This patch fixes two things:
> - Make it easier to run asterisk as non-root
> - Eliminate a local patch for the OpenBSD port
> 
> 
> Diffs
> -----
> 
>   trunk/Makefile 172314 
>   trunk/contrib/init.d/rc.archlinux.asterisk 172314 
>   trunk/contrib/init.d/rc.debian.asterisk 172314 
>   trunk/contrib/scripts/safe_asterisk 172314 
> 
> Diff: http://reviewboard.digium.com/r/139/diff
> 
> 
> Testing
> -------
> 
> compiles, installs and runs fine on freebsd7, openbsd 4.4, openbsd current and ubuntu 8.10 on both i386 and amd64
> 
> 
> Thanks,
> 
> Michiel
> 
>




More information about the asterisk-dev mailing list