[asterisk-dev] [Code Review] Fix fd leak when using HTTP AMI sessions

[Mark Michelson]

vadim at mbdsys.com wrote:
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.digium.com/r/148/#review378
> -----------------------------------------------------------
> 
> 
> Why don't you keep old mansession as mansession and call the new structure actioninfo for example
> 
> - vadim
> 

It would make a lot of sense to do this, but the problem is due to the fact that 
manager actions require a mansession structure as an argument, not an actioninfo 
structure. Similarly, the struct that is passed to public manager functions has 
to be a mansession also. Of top of that, because of the nature of how Manager 
actions are handled, we have to stuff the session information inside the action 
information, not the other way around.

Kevin and I talked about this for quite a while before coming up with this 
method for handling it and we couldn't think of anything else that would work.

Mark Michelson