[asterisk-dev] [Code Review] Adding immediate yes/no option to iax.conf

[Russell Bryant]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.digium.com/r/143/#review364
-----------------------------------------------------------

Ship it!


I just had these few minor comments.  After that, I'm okay with it.



/trunk/channels/chan_iax2.c
<http://reviewboard.digium.com/r/143/#comment878>

    Indent the inline documentation with spaces



/trunk/channels/chan_iax2.c
<http://reviewboard.digium.com/r/143/#comment879>

    1) According to coding guidelines, the goto needs to be on a new line.  Also, I would add curly braces.
    
    2) The use of the goto here seems a bit evil.  However, based on how this code is structured, I don't know of a better way to do it, so I guess it's okay.



/trunk/configs/iax.conf.sample
<http://reviewboard.digium.com/r/143/#comment877>

    It seems odd that the new example entry in the configuration file isn't actually using the new option.


- Russell


On 2009-02-05 16:50:12, David Vossel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.digium.com/r/143/
> -----------------------------------------------------------
> 
> (Updated 2009-02-05 16:50:12)
> 
> 
> Review request for Asterisk Developers, Russell Bryant and Mark Michelson.
> 
> 
> Summary
> -------
> 
> jcovert submitted this patch via our bug tracker.  I tested it in trunk and it works.  Here's his description. "IAX phones and devices (such as the IAXy) are cool. When you pick up the phone, a message is sent (even before you dial), and just like on the DAHDI FSX devices, code gets executed.
> 
> DAHDI has "immediate=yes" so that when you pick up the phone, you get connected directly to the "s" extension. This is useful for lobby phones, elevator phones, manual service (number please), etc.
> 
> It was nearly trivial to implement in chan_iax2.c. I made a deliberate decision to only implement it for users/friends who authenticate (as any properly connected phone or ATA would). Simply add "immediate=yes" in the friend or user definition, and when you pick up the phone, instead of dialtone, you go right to extension "s" in the appropriate context."
> 
> 
> This addresses bug 0014266.
>     http://bugs.digium.com/view.php?id=0014266
> 
> 
> Diffs
> -----
> 
>   /trunk/channels/chan_iax2.c 173769 
>   /trunk/configs/iax.conf.sample 173769 
> 
> Diff: http://reviewboard.digium.com/r/143/diff
> 
> 
> Testing
> -------
> 
> Tested in trunk with immediate option on and off.  seems to work find to me. 
> 
> 
> Thanks,
> 
> David
> 
>