[asterisk-dev] [Code Review] inotify support for checking timezone file modification

[Russell Bryant]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.digium.com/r/136/#review354
-----------------------------------------------------------



/trunk/main/stdtime/localtime.c
<http://reviewboard.digium.com/r/136/#comment865>

    This code is not sufficient to ensure that the thread is up and initialized.  You need to use a lock and condition to ensure that you wait long enough.  You can use a temporary lock and condition on the stack if you want since it is only needed while you start up the new thread.
    
    Thread1:
    
    lock()
    create_thread2()
    cond_wait()
    unlock()
    
    Thread2:
    
    initialize()
    
    lock()
    signal()
    unlock()
    


- Russell


On 2009-01-27 15:06:22, Tilghman Lesher wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.digium.com/r/136/
> -----------------------------------------------------------
> 
> (Updated 2009-01-27 15:06:22)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Use the inotify(7) interface to delete cached timezone entries, when the underlying file changes.
> 
> 
> This addresses bug 14300.
>     http://bugs.digium.com/view.php?id=14300
> 
> 
> Diffs
> -----
> 
>   /trunk/configure 171187 
>   /trunk/configure.ac 171187 
>   /trunk/include/asterisk/autoconfig.h.in 171187 
>   /trunk/main/stdtime/localtime.c 171187 
> 
> Diff: http://reviewboard.digium.com/r/136/diff
> 
> 
> Testing
> -------
> 
> Compile-time only.
> 
> 
> Thanks,
> 
> Tilghman
> 
>