[asterisk-dev] [svn-commits] mmichelson: manager logout cli
Mark Michelson
mmichelson at digium.com
Tue Feb 3 07:37:56 CST 2009
Johansson Olle E wrote:
> Some comments:
>
> 1. Please add a manager event to tell the user that he's logged out by
> the CLI.
> We might have other reasons to send this, like a shutdown.
> 2. Are we sure we can do this? If the manager client is in the middle
> of receiving
> a list of events - like 200 SIP peers - and someone logs him out
> from the CLI,
> will bad things happen in other parts of the code when the
> mansession
> disappears? Do we actually check for that? Does the locking code
> here
> take care of it properly?
>
> Just being worried...
>
> /O
>
>
Your worriedness is justified. I reverted this commit about 10 minutes
after I put it in due to potential problems.
Mark Michelson
More information about the asterisk-dev
mailing list