[asterisk-dev] mmichelson: trunk r173028 - in /trunk: CHANGES main/manager.c

[Russell Bryant]

SVN commits to the Digium repositories wrote:
> Author: mmichelson
> Date: Mon Feb  2 17:10:47 2009
> New Revision: 173028
> 
> URL: http://svn.digium.com/svn-view/asterisk?view=rev&rev=173028
> Log:
> Add a CLI command to log out a manager user
> 
> (closes issue #13877)
> Reported by: eliel
> Patches:
>       cli_manager_logout.patch.txt uploaded by eliel (license 64)
> Tested by: eliel, putnopvut
> +	/*
> +	char *choice[] = { "from", NULL };
> +	*/
> +

> +	case CLI_GENERATE:
> +		/*
> +		if (a->pos == 3) {
> +			return ast_cli_complete(a->word, choice, a->n);
> +		}
> +		*/

Is there any reason this stuff is commented out?

> +			AST_LIST_REMOVE_CURRENT(list);
> +			ast_mutex_lock(&s->__lock);
> +			if (s->waiting_thread != AST_PTHREADT_NULL) {
> +				pthread_kill(s->waiting_thread, SIGURG);
> +			}
> +			ast_mutex_unlock(&s->__lock);
> +			ast_atomic_fetchadd_int(&num_sessions, -1);
> +			free_session(s);

Please see http://reviewboard.digium.com/r/77/ for details on a 
significant problem with this code.

-- 
Russell Bryant
Digium, Inc. | Senior Software Engineer, Open Source Team Lead
445 Jan Davis Drive NW - Huntsville, AL 35806 - USA
Check us out at: www.digium.com & www.asterisk.org