[asterisk-dev] [Code Review] Bridging API for Conference Bridge purposes

[Joshua Colp]

> On 2009-02-01 04:12:00, vadim wrote:
> > /trunk/bridges/bridge_softmix.c, lines 229-234
> > <http://reviewboard.digium.com/r/93/diff/2/?file=2255#file2255line229>
> >
> >     i think that following will be more efficient:
> >     
> >     memcpy(sc->final_buf, buf, sizeof(sc->final_buf));
> >     if (sc->have_audio)
> >        for (i = 0; i < SOFTMIX_DATALEN; i++) {
> >     	ast_slinear_saturated_subtract(&sc->final_buf[i], &sc->our_buf[i]);
> >        }
> >     
> >

Done.


> On 2009-02-01 04:12:00, vadim wrote:
> > /trunk/main/bridging.c, lines 1023-1028
> > <http://reviewboard.digium.com/r/93/diff/2/?file=2260#file2260line1023>
> >
> >     I beleive that to avoid deadlocks one need to unlock objects in the inverse order of locking

Done.


> On 2009-02-01 04:12:00, vadim wrote:
> > /trunk/main/bridging.c, lines 1033-1038
> > <http://reviewboard.digium.com/r/93/diff/2/?file=2260#file2260line1033>
> >
> >     unlock order

Done.


> On 2009-02-01 04:12:00, vadim wrote:
> > /trunk/main/bridging.c, lines 1090-1091
> > <http://reviewboard.digium.com/r/93/diff/2/?file=2260#file2260line1090>
> >
> >     Unlock order

Done.


- Joshua


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.digium.com/r/93/#review348
-----------------------------------------------------------


On 2008-12-31 15:45:07, Joshua Colp wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.digium.com/r/93/
> -----------------------------------------------------------
> 
> (Updated 2008-12-31 15:45:07)
> 
> 
> Review request for Asterisk Developers and Russell Bryant.
> 
> 
> Summary
> -------
> 
> This patch implements the new bridging API and brings with it a module for conference bridges. It does *not* replace existing internal bridging or features yet and will not cause any regressions when put in. It will essentially be introduced as a first test phase to work out any unforeseen critical issues. The bridging core itself is fully implemented besides the following: jitterbuffer support, native bridging, and interval hooks (hooks that are time based versus action based). If you would like an explanation of what the bridging API is made up of and how it works that can be found in the bridging.h header file.
> 
> 
> Diffs
> -----
> 
>   /trunk/Makefile 164597 
>   /trunk/apps/app_confbridge.c PRE-CREATION 
>   /trunk/bridges/Makefile PRE-CREATION 
>   /trunk/bridges/bridge_multiplexed.c PRE-CREATION 
>   /trunk/bridges/bridge_simple.c PRE-CREATION 
>   /trunk/bridges/bridge_softmix.c PRE-CREATION 
>   /trunk/channels/chan_bridge.c PRE-CREATION 
>   /trunk/include/asterisk/bridging.h PRE-CREATION 
>   /trunk/include/asterisk/channel.h 164597 
>   /trunk/main/Makefile 164597 
>   /trunk/main/bridging.c PRE-CREATION 
> 
> Diff: http://reviewboard.digium.com/r/93/diff
> 
> 
> Testing
> -------
> 
> Conference bridge testing using app_confbridge with features. Joining two channels with simple frame exchange and joining three channels to move it to a true conference bridge. IVR capability of app_confbridge was also tested.
> 
> 
> Thanks,
> 
> Joshua
> 
>