[asterisk-dev] [Code Review] Added ability to perform SRV lookups for AGI URIs

[Brent Thomson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/378/
-----------------------------------------------------------

(Updated 2009-12-31 11:15:05.698679)


Review request for Asterisk Developers.


Changes
-------

Here is a new patch using the approach OEJ suggested and tilghman worked on. We've added a few tweaks to polish it up, too.


Summary
-------

With this patch, you can run the Agi() dial plan application with a URI beginning with hagi:// (for HA Agi) to indicate that the host name should be resolved as an SRV service instead of a regular host name.

Regular Agi still works the same. Hagi URIs should look like this in your dial plan:

    exten => _X.,1,Agi(hagi://example.com/foo.agi)

Asterisk will look up _agi._tcp.example.com and will try the normal fastagi routine on each host:port in the result until one accepts the connection or all results fail. 


This addresses bug 0014775.
    https://issues.asterisk.org/view.php?id=0014775


Diffs (updated)
-----

  /trunk/CHANGES 234369 
  /trunk/include/asterisk/srv.h 234369 
  /trunk/main/srv.c 234369 
  /trunk/res/res_agi.c 234369 

Diff: https://reviewboard.asterisk.org/r/378/diff


Testing
-------

* Made formatting changes per eliel's comments.
* Sniffing traffic shows correct DNS lookups, load balancing, and failover.
* Resulting AGI connections work as expected.
* Running for 6 months without issue.


Thanks,

Brent