[asterisk-dev] [Code Review] Allow app_dial to play 'indication tone while ringing' like 'option m' which will provide music on hold while ringing

Russell Bryant russell at digium.com
Fri Dec 18 10:16:53 CST 2009

This is an automatically generated e-mail. To reply, visit:

(Updated 2009-12-18 10:16:52.933649)

Review request for Asterisk Developers.


Corrected description. Option 'm' sends Progress, not Proceeding.

Summary (updated)

This senario is based on an ETSI ISDN installation, but I'm sure applies to others.

option 'r' sends a Ringing Indication to the network, which informs the network we can deliver the call, but ultimately we may not be able to, and need to issue Congestion.
option 'm' sends a Progress Indication, which allows us to indicate Congestion and then let the call go, the network providor can then try the next provider.

The current ugly solution, is to record a music file, of Ringing, and play it, something like.
  exten => 80,1,Dial(DAHDI/2,30,m(myring))
  exten => 80,n,Congestion()

This patch provides an optional argument for option 'r' as in 'r(vodaring)'

Now a tidy and customizable way to play out any tones from the indications.conf file like.
  exten => 80,1,Dial(DAHDI/2,30,r(vodaring))
  exten => 80,n,Congestion()

This addresses bug 14504.


  trunk/apps/app_dial.c 235418 

Diff: https://reviewboard.asterisk.org/r/448/diff


100% test results with examples below.

exten => 80,1,Dial(DAHDI/2,,r(vodaring))
exten => 80,1,Dial(DAHDI/2,,r)
exten => 80,1,Dial(DAHDI/2,,m)
exten => 80,1,Dial(DAHDI/2,,)



More information about the asterisk-dev mailing list