[asterisk-dev] [Code Review] Allow app_dial to play 'indication tone while ringing' like 'option m' which will provide music on hold while ringing

[Russell Bryant]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/448/#review1316
-----------------------------------------------------------



trunk/apps/app_dial.c
<https://reviewboard.asterisk.org/r/448/#comment3043>

    There is a code path here that can lead to a leaked tone_zone_sound reference leak.


- Russell


On 2009-12-16 04:55:24, Alec Davis wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/448/
> -----------------------------------------------------------
> 
> (Updated 2009-12-16 04:55:24)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> This senario is based on an ETSI ISDN installation, but I'm sure applies to others.
> 
> option 'r' sends a Ringing Indication to the network, which informs the network we can deliver the call, but ultimately we may not be able to, and need to issue Congestion.
> option 'm' sends a Proceeding Indication, which allows us to indicate Congestion and let the call go, and let the network providor try the next provider.
> 
> The current ugly solution, is to record a music file, of Ringing, and play it, something like.
>   exten => 80,1,Dial(DAHDI/2,30,m(myring))
>   exten => 80,n,Congestion()
> 
> This patch provides an optional argument for option 'r' as in 'r(vodaring)'
> 
> Now a tidy and customizable way to play out any tones from the indications.conf file like.
>   exten => 80,1,Dial(DAHDI/2,30,r(vodaring))
>   exten => 80,n,Congestion()
> 
> 
> This addresses bug 14504.
>     https://issues.asterisk.org/view.php?id=14504
> 
> 
> Diffs
> -----
> 
>   trunk/apps/app_dial.c 231431 
> 
> Diff: https://reviewboard.asterisk.org/r/448/diff
> 
> 
> Testing
> -------
> 
> 100% test results with examples below.
> 
> exten => 80,1,Dial(DAHDI/2,,r(vodaring))
> exten => 80,1,Dial(DAHDI/2,,r)
> exten => 80,1,Dial(DAHDI/2,,m)
> exten => 80,1,Dial(DAHDI/2,,)
> 
> 
> Thanks,
> 
> Alec
> 
>