[asterisk-dev] [Code Review] Unit Test Framework

[Russell Bryant]

> On 2009-12-16 15:49:39, Matthew Nicholson wrote:
> > /trunk/include/asterisk/test.h, lines 105-109
> > <https://reviewboard.asterisk.org/r/447/diff/1/?file=7560#file7560line105>
> >
> >     Should there also be an AST_TEST_XFAIL result state for expected failures?
> >     
> >     And perhaps also an AST_TEST_ERROR state?  This would be used in the event that there was an error running a test that is unrelated to what the test is testing.  Things such as a memory allocation error.
> 
> David Vossel wrote:
>     If a test is expected to fail, would that not just be considered a pass?  Why would we need to differentiate the two?

Regarding an expected failure, can you provide a use case?

Also, if a memory allocation error occurs, I would call that a test failure.  I would them expect the text that accompanies the error to indicate that the failure was due to memory allocation.  I don't think it needs to be any more complicated than that.


- Russell


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/447/#review1311
-----------------------------------------------------------


On 2009-12-15 18:15:17, David Vossel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/447/
> -----------------------------------------------------------
> 
> (Updated 2009-12-15 18:15:17)
> 
> 
> Review request for Asterisk Developers and Russell Bryant.
> 
> 
> Summary
> -------
> 
> The Unit Test Framework is a new API that manages registration and execution of unit tests in Asterisk with the purpose of verifying the operation of C functions.
> 
> The Framework consists of a single test manager accompanied by a list of registered test functions defined within the code.  A test is defined, registered, and unregistered from the framework using a set of macros which allow the test code to only be compiled within asterisk when the TEST_FRAMEWORK flag is enabled in menuselect.  This allows the test code to exist in the same file as the C functions it intends to verify.  Registered tests may be viewed and executed via a set of new CLI commands.  CLI commands are also present for generating and exporting test results into xml and txt formats.
> 
> For more information and use cases please refer to the documentation provided at the beginning of the test.h file.
> 
> 
> Diffs
> -----
> 
>   /trunk/build_tools/cflags-devmode.xml 235225 
>   /trunk/include/asterisk/test.h PRE-CREATION 
>   /trunk/main/asterisk.c 235225 
>   /trunk/main/test.c PRE-CREATION 
>   /trunk/tests/test_heap.c 235225 
> 
> Diff: https://reviewboard.asterisk.org/r/447/diff
> 
> 
> Testing
> -------
> 
> test_heap.c has been modified to take advantage of the Test Framework.  I have executed and generated reports for these tests. 
> 
> 
> Thanks,
> 
> David
> 
>