[asterisk-dev] [Code Review] Allow app_dial to play 'indication tone while ringing' like 'option m' which will provide music on hold while ringing

[Alec Davis]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/448/
-----------------------------------------------------------

Review request for Asterisk Developers.


Summary
-------

option 'r' sends a Ringing indication to the network, which informs the network we can deliver the call, but ultimately we may not be able to, and need to issue Congestion.
option 'm' only sends Proceeding Indication, which allows us to indicate Congestion and call to fail with us, and the network providor to try the next provider.

And ugly solution, is to record a music file, of Ringing, and play it, something like.
  exten => 80,1,Dial(DAHDI/2,,m(myring))

This patch provides an optional argument to option 'r' as in 'r(vodaring)'

Now a tidy and customizable way to play out any tones from the indications.conf file like.
   exten => 80,1,Dial(DAHDI/2,,r(vodaring))


This addresses bug 14504.
    https://issues.asterisk.org/view.php?id=14504


Diffs
-----

  trunk/apps/app_dial.c 231431 

Diff: https://reviewboard.asterisk.org/r/448/diff


Testing
-------

100% test results with examples below.

exten => 80,1,Dial(DAHDI/2,,r(vodaring))
exten => 80,1,Dial(DAHDI/2,,r)
exten => 80,1,Dial(DAHDI/2,,m)
exten => 80,1,Dial(DAHDI/2,,)


Thanks,

Alec