[asterisk-dev] [Code Review] Cancel retries for all dialogs when the remote host isn't answering

[Mark Michelson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/446/#review1297
-----------------------------------------------------------


This looks a lot more reasonable to me. Has it been confirmed by anyone that this new version solves the problem? If so, then by all means, ship it!

- Mark


On 2009-12-09 14:36:27, Tilghman Lesher wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/446/
> -----------------------------------------------------------
> 
> (Updated 2009-12-09 14:36:27)
> 
> 
> Review request for Asterisk Developers and Russell Bryant.
> 
> 
> Summary
> -------
> 
> Currently, certain dialogs, including INVITE, may never deallocate resources, if the remote host does not ACK the packets.  This is due to a retry loop in the autodestruct function that has no terminating condition.
> 
> 
> This addresses bug 15627.
>     https://issues.asterisk.org/view.php?id=15627
> 
> 
> Diffs
> -----
> 
>   /branches/1.4/channels/chan_sip.c 233049 
> 
> Diff: https://reviewboard.asterisk.org/r/446/diff
> 
> 
> Testing
> -------
> 
> Works to solve reporter's problem.
> 
> 
> Thanks,
> 
> Tilghman
> 
>