[asterisk-dev] [Code Review] Cancel retries for all dialogs when the remote host isn't answering

[David Vossel]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/446/#review1293
-----------------------------------------------------------


I thought after a certain amount of retries the packet would be destroyed if it was never ACKED.  I'd expect that to break the autodestruct reschedule loop allowing the dialog to be destroyed if the SIP_NEEDDESTROY flag was never set.  Since TCP and TLS is not retransmitted, perhaps that would cause this condition to never be reached, I'm not sure how that is handled.


/branches/1.4/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/446/#comment2959>

    It just seems like there should be some cleaner way of doing this. I understand why it is being done, but I'm just afraid it might lead to confusion during debugging since no SIP_CANCEL message is actually being transmitted.
    


- David


On 2009-12-09 09:52:44, Tilghman Lesher wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/446/
> -----------------------------------------------------------
> 
> (Updated 2009-12-09 09:52:44)
> 
> 
> Review request for Asterisk Developers and Russell Bryant.
> 
> 
> Summary
> -------
> 
> Currently, certain dialogs, including INVITE, may never deallocate resources, if the remote host does not ACK the packets.  This is due to a retry loop in the autodestruct function that has no terminating condition.
> 
> 
> This addresses bug 15627.
>     https://issues.asterisk.org/view.php?id=15627
> 
> 
> Diffs
> -----
> 
>   /branches/1.4/channels/chan_sip.c 233049 
> 
> Diff: https://reviewboard.asterisk.org/r/446/diff
> 
> 
> Testing
> -------
> 
> Works to solve reporter's problem.
> 
> 
> Thanks,
> 
> Tilghman
> 
>