[asterisk-dev] [Code Review] Fix minor bugs preventing EIVR socket client from working

Russell Bryant russell at digium.com
Mon Dec 7 13:33:39 CST 2009


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/439/#review1284
-----------------------------------------------------------

Ship it!


- Russell


On 2009-12-03 10:45:53, thedavidfactor wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/439/
> -----------------------------------------------------------
> 
> (Updated 2009-12-03 10:45:53)
> 
> 
> Review request for Asterisk Developers and Chris Tooley.
> 
> 
> Summary
> -------
> 
> fix a couple of very minor bugs that prevent the socket client from working. The wrong set of properties were used in one place and the size of the address variable isn't set if the host name is an ip address. Also includes a fix for a bug that was introduced previously.
> 
> 
> This addresses bug 16121.
>     https://issues.asterisk.org/view.php?id=16121
> 
> 
> Diffs
> -----
> 
>   /trunk/apps/app_externalivr.c 232587 
> 
> Diff: https://reviewboard.asterisk.org/r/439/diff
> 
> 
> Testing
> -------
> 
> actively in use to develop socket based EIVR clients.
> 
> 
> Thanks,
> 
> thedavidfactor
> 
>




More information about the asterisk-dev mailing list