[asterisk-dev] SIP URI checking in chan_sip.c

[Olle E. Johansson]

1 dec 2009 kl. 01.37 skrev Kirill 'Big K' Katsnelson:

> is nonexistent. Asterisk happily accepts URLs with invalid characters in 
> them, even in pedantic mode (that one takes care of %xx hex 
> substitutions only), and eventually leaks handles and crashes because of 
> that. See my previous message <4B138244.8070000 at adaptiveai.com> "Failure 
> on multiple malformed SIP URI".
What's you bug report # ?
> 
> Questions:
> 
> 1. Why the pedantic mode exists at all, and is even off by default 
> (non-RFC compliant SIP handling)?
History mostly. It was the first thing I removed when I forked the sip channel twice...
> 
> 2. Is that a problem that needs to be fixed? Am I missing anything? Yes 
> crash is a problem, but how exactly that should be fixed:
>  - non-compiant URLs rejected, or
>  - non-compliant URLS accepted and digested without crashing?
We should reject it with an error message.
I can't find out from your mail what type of SIP message that causes this, but I'm eager to know so that we can handle this with some speed.

Regards,
/O
> 
> I am for the former solution, as these are rejected by UAC anyway.
> 
> I am just trying to understand from what end I should approach the problem.
> 
> Thanks,
> 
>  -kkm
> 
> _______________________________________________
> --Bandwidth and Colocation Provided by http://www.api-digital.com--
> 
> asterisk-dev mailing list
> To UNSUBSCRIBE or update options visit:
>   http://lists.digium.com/mailman/listinfo/asterisk-dev

---
* Olle E Johansson - oej at edvina.net
* Cell phone +46 70 593 68 51, Office +46 8 96 40 20, Sweden