[asterisk-dev] [Code Review] CLI filtering [GSoC 2009]

[Eliel Sardañons]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/336/#review1009
-----------------------------------------------------------



/trunk/main/logger.c
<https://reviewboard.asterisk.org/r/336/#comment2391>

    Maybe you can use an enum {} instead of a plain number here.



/trunk/main/logger.c
<https://reviewboard.asterisk.org/r/336/#comment2401>

    Coding guidelines, use:
    
    if (!filter) {
    
    }
    
    without spaces.



/trunk/main/logger.c
<https://reviewboard.asterisk.org/r/336/#comment2404>

    Use this to avoid indenting:
    if (!channels) {
         return 0;
    }
    
    ... then continue ...



/trunk/main/logger.c
<https://reviewboard.asterisk.org/r/336/#comment2396>

    Put this at the end of the AST_LIST_TRAVERSE_SAFE_BEGIN() {
    
    }
    AST_LIST_TRAVERSE_SAFE_END;
    



/trunk/main/logger.c
<https://reviewboard.asterisk.org/r/336/#comment2406>

    Avoid all this indented code:
    if (!channels) {
          return -1;
    }
     ... continue ...



/trunk/main/logger.c
<https://reviewboard.asterisk.org/r/336/#comment2392>

    Use doxygen



/trunk/main/logger.c
<https://reviewboard.asterisk.org/r/336/#comment2393>

    Remove trailing whitespaces.


- Eliel


On 2009-08-06 22:01:42, junky wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/336/
> -----------------------------------------------------------
> 
> (Updated 2009-08-06 22:01:42)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> CLI filtering for the gsoc 2009
> 
> This is the first patch to add functionality to filter CLI.
> 
> 
> See usages and examples in doc/cli_filters.txt
> 
> 
> Diffs
> -----
> 
>   /trunk/channels/chan_agent.c 210860 
>   /trunk/channels/chan_alsa.c 210860 
>   /trunk/channels/chan_bridge.c 210860 
>   /trunk/channels/chan_dahdi.c 210860 
>   /trunk/channels/chan_gtalk.c 210860 
>   /trunk/channels/chan_h323.c 210860 
>   /trunk/channels/chan_iax2.c 210860 
>   /trunk/channels/chan_jingle.c 210860 
>   /trunk/channels/chan_local.c 210860 
>   /trunk/channels/chan_mgcp.c 210860 
>   /trunk/channels/chan_misdn.c 210860 
>   /trunk/channels/chan_multicast_rtp.c 210860 
>   /trunk/channels/chan_nbs.c 210860 
>   /trunk/channels/chan_oss.c 210860 
>   /trunk/channels/chan_phone.c 210860 
>   /trunk/channels/chan_skinny.c 210860 
>   /trunk/channels/chan_unistim.c 210860 
>   /trunk/channels/chan_usbradio.c 210860 
>   /trunk/channels/chan_vpb.cc 210860 
>   /trunk/include/asterisk/logger.h 210860 
>   /trunk/include/asterisk/pbx.h 210860 
>   /trunk/include/asterisk/threadstorage.h 210860 
>   /trunk/main/logger.c 210860 
>   /trunk/main/manager.c 210860 
>   /trunk/main/pbx.c 210860 
>   /trunk/main/threadstorage.c 210860 
> 
> Diff: https://reviewboard.asterisk.org/r/336/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> junky
> 
>