[asterisk-dev] sruffell: linux/trunk r6524 - /linux/trunk/drivers/dahdi/dahdi_dummy.c

[Tony Mountifield]

In article <E1LzDte-0002CA-Bh at wibble.digium.internal>,
SVN commits to the Digium repositories <svn-commits at lists.digium.com> wrote:
> - * Converted to use RTC on i386 by Tony Mountifield <tony at softins.co.uk>

Well, it was good while it lasted... :-)

But seriously, one comment:

> +#define JIFFIES_INTERVAL (HZ/250) 	/* 4ms is fine for dahdi_dummy */

If it is possible to have a system where HZ is less than 250, this won't
work on such a system. I think HZ=100 has been seen quite often.

#define XX 250	/* times per second we want to call dahdi */
#if HZ < XX
#define JIFFIES_INTERVAL 1
#else
#define JIFFIES_INTERVAL (HZ/XX)    /* 4ms is fine for dahdi_dummy */
#endif

Replacing XX with a suitably descriptive symbol name.

Cheers
Tony
-- 
Tony Mountifield
Work: tony at softins.co.uk - http://www.softins.co.uk
Play: tony at mountifield.org - http://tony.mountifield.org