[asterisk-dev] [Code Review] TLS/SSL private key option

[Kevin Fleming]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.digium.com/r/234/#review748
-----------------------------------------------------------

Ship it!


My only comment is that the name 'private' is too ambiguous; it could mean that the file could contain *other* private stuff besides the key, but that's not true. Either 'key' or 'privatekey' would be preferable. Otherwise this looks good.


- Kevin


On 2009-04-24 11:58:27, David Vossel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.digium.com/r/234/
> -----------------------------------------------------------
> 
> (Updated 2009-04-24 11:58:27)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Adds option to specify a private key .pem file when configuring TLS or SSL in AMI, HTTP, and SIP.  Before this, the certificate file was used for both the public and private key.  It is possible for this file to hold both, but most configurations allow for a separate private key file to be specified.  Clarified in .conf files how these options are to be used.  The current conf files do not explain how the private key is handled at all, so without knowledge of Asterisk's TLS implementation, it would be hard to know for sure what was going on or how to set it up.
> 
> 
> Diffs
> -----
> 
>   /trunk/main/tcptls.c 190453 
>   /trunk/include/asterisk/tcptls.h 190453 
>   /trunk/main/http.c 190453 
>   /trunk/main/manager.c 190453 
>   /trunk/configs/sip.conf.sample 190453 
>   /trunk/configs/manager.conf.sample 190453 
>   /trunk/configs/http.conf.sample 190453 
>   /trunk/CHANGES 190453 
>   /trunk/channels/chan_sip.c 190453 
> 
> Diff: http://reviewboard.digium.com/r/234/diff
> 
> 
> Testing
> -------
> 
> tested it with sip, loads files correctly
> 
> 
> Thanks,
> 
> David
> 
>