[asterisk-dev] [svn-commits] file: branch 1.6.2 r188070 - in /branches/1.6.2: ./ channels/chan_sip.c

[Olle E. Johansson]

14 apr 2009 kl. 14.49 skrev Joshua Colp:

> ----- "Olle E. Johansson" <oej at edvina.net> wrote:
>
>> 13 apr 2009 kl. 18.34 skrev SVN commits to the Digium repositories:
>>
>>> Fix a bug where using an outbound proxy would cause the local
>>> address to be 127.0.0.1.
>>>
>>> Copy the outbound proxy IP address into the SIP dialog structure as
>>
>>> the IP address we will
>>> be sending to. This has to be done because the logic that
>>> determines what local IP address to use
>>> in the SIP messages is not aware of an outbound proxy being in
>>> place. It only knows what IP address
>>> we are sending to.
>>
>>
>> This might be a problem, since only the first packet should be forced
>>
>> to go to the outbound proxy,
>> unless we've set the force option. We do need to keep the original
>> address if we have it for subsequent
>> requests, or recalculate it for the second request.
>>
>
> This commit doesn't actually cause the code to use the field I  
> changed to send
> the packet. It's only used to determine the local IP address. The  
> outbound proxy
> is still respected exactly as it was previously. Although it may not  
> behave as it should
> in which case we've got a bug we should narrow down.

The outbound proxy code still needs love to be back to known state  
before
the addition of tcp/tls to the code, as I've noted in the code of  
chan_sip,
so testing will be needed anyway.

/O