[asterisk-dev] [Code Review] Detect if we need bison to regenerate main/ast_expr2.c during ./configure

Michiel van Baak michiel at vanbaak.info
Wed Apr 1 14:46:40 CDT 2009


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.digium.com/r/215/
-----------------------------------------------------------

Review request for Asterisk Developers.


Summary
-------

A clean svn checkout needs bison to compile but configure does not check for it.
If you are not using the LAN to origsvn main/ast_expr2.y is probably newer then main/ast_expr2.c so the compile will try to regenerate main/ast_expr2.c

This patch (basically a patch created by corydon and modified by me to bailout) will make configure bailout if there's an .svn directory and ast_expr2.y is never then ast_expr2.c and 'svn diff main/ast_expr2.y' indicates it's actually changed. Otherwise it will 'touch main/ast_expr2.c' to update it's timestamp so the make process wont try to regenerate the .c file.


This addresses bug 14706.
    http://bugs.digium.com/view.php?id=14706


Diffs
-----

  trunk/configure.ac 185908 

Diff: http://reviewboard.digium.com/r/215/diff


Testing
-------

Uninstalled bison, ran svn co, and no bison was needed with this patch. Without this patch the compile died on trying to regenerate the .c file.

Tested on Ubuntu 8.10 amd64 and OpenBSD 4.5 amd64 (not that arch really matters here)


Thanks,

Michiel




More information about the asterisk-dev mailing list