[asterisk-dev] [Code Review] Add technology independent static control

[Jared Smith]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.digium.com/r/214/#review662
-----------------------------------------------------------

Ship it!


Fix the items below... and then ship it like there's no tomorrow!



/trunk/funcs/func_static.c
<http://reviewboard.digium.com/r/214/#comment1709>

    This looks funny... but I guess it's valid if it doesn't take any parameters.



/trunk/funcs/func_static.c
<http://reviewboard.digium.com/r/214/#comment1710>

    Shouldn't we make the DTMF sequences customizable in features.conf?  Or via parameters?  I'd hate to go to do a blind transfer and accidentally put static on the line instead... on second thought, I'd love to do that!



/trunk/funcs/func_static.c
<http://reviewboard.digium.com/r/214/#comment1712>

    Is this really white noise?  What about an option for pink noise as well?



/trunk/funcs/func_static.c
<http://reviewboard.digium.com/r/214/#comment1713>

    This notice is not descriptive enough... If I got a warning that said "bad direction", I'd think it was the GPS in my car telling me to make another U-turn.



/trunk/funcs/func_static.c
<http://reviewboard.digium.com/r/214/#comment1714>

    Shouldn't this audiohook be named "Static" or "White Noise" instead of "Volume"?


- Jared


On 2009-04-01 09:10:10, Russell Bryant wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.digium.com/r/214/
> -----------------------------------------------------------
> 
> (Updated 2009-04-01 09:10:10)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> This is the feature that you have all been waiting for.
> 
> This new function allows you to introduce static into a phone call.  The common use case is as an excuse to get off of an annoying phone call.  If someone won't stop talking, just start increasing the static until you can't hear each other anymore.  Problem solved!
> 
> 
> Diffs
> -----
> 
>   /trunk/funcs/func_static.c PRE-CREATION 
> 
> Diff: http://reviewboard.digium.com/r/214/diff
> 
> 
> Testing
> -------
> 
> exten => 1234,1,Set(STATIC()=0) ; Set up STATIC() so I can control it via DTMF during the call
> exten => 1234,N,Dial(SIP/1234)  ; When 1234 gets annoying, start pressing '*' to increase static
> 
> I tested an extension like the above and verified that I could increase and decrease the static at will.
> 
> 
> Thanks,
> 
> Russell
> 
>