[asterisk-dev] [Code Review] Add technology independent static control

[Mark Michelson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.digium.com/r/214/#review663
-----------------------------------------------------------

Ship it!


This is what the community has been begging for!


/trunk/funcs/func_static.c
<http://reviewboard.digium.com/r/214/#comment1711>

    This will allow static values between 32767 and 65535, which are invalid. You should add some ceiling logic to this.


- Mark


On 2009-04-01 08:56:19, Russell Bryant wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.digium.com/r/214/
> -----------------------------------------------------------
> 
> (Updated 2009-04-01 08:56:19)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> This is the feature that you have all been waiting for.
> 
> This new function allows you to introduce static into a phone call.  The common use case is as an excuse to get off of an annoying phone call.  If someone won't stop talking, just start increasing the static until you can't hear each other anymore.  Problem solved!
> 
> 
> Diffs
> -----
> 
>   /trunk/funcs/func_static.c PRE-CREATION 
> 
> Diff: http://reviewboard.digium.com/r/214/diff
> 
> 
> Testing
> -------
> 
> exten => 1234,1,Set(STATIC()=0) ; Set up STATIC() so I can control it via DTMF during the call
> exten => 1234,N,Dial(SIP/1234)  ; When 1234 gets annoying, start pressing '*' to increase static
> 
> I tested an extension like the above and verified that I could increase and decrease the static at will.
> 
> 
> Thanks,
> 
> Russell
> 
>