[asterisk-dev] [Code Review] Patch pbx_dundi.c to periodically clean it's database cache

Matthew Nicholson mnicholson at digium.com
Fri Nov 21 15:03:22 CST 2008



> On 2008-11-21 14:10:30, Matthew Nicholson wrote:
> > I was not sure wether ast_debug() or dundi_debug_output() should be used here.

Disregard this comment.


- Matthew


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.digium.com/r/63/#review149
-----------------------------------------------------------


On 2008-11-21 14:01:48, Matthew Nicholson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.digium.com/r/63/
> -----------------------------------------------------------
> 
> (Updated 2008-11-21 14:01:48)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> This is a modified version of the patch from bug 13819 (http://bugs.digium.com/view.php?id=13819).  It spawns a thread to remove expired entries from the dundi cache (in astdb) every 60 seconds.  This patch is necessary because asterisk normally cleans these entries when they are looked up, but entries that are not retrieved often (or retrieved only once ever) will stay in the database.
> 
> 
> This addresses bug 13819.
>     http://bugs.digium.com/view.php?id=13819
> 
> 
> Diffs
> -----
> 
>   /branches/1.6.0/pbx/pbx_dundi.c 158369 
> 
> Diff: http://reviewboard.digium.com/r/63/diff
> 
> 
> Testing
> -------
> 
> I tested this by creating some expired entries in the database using 'database put dundi/cache test 0|0' and observed asterisk clean them up.
> 
> 
> Thanks,
> 
> Matthew
> 
>




More information about the asterisk-dev mailing list