[asterisk-dev] [Code Review] Fix crash due to new end_bridge_callback code

Mark Michelson mmichelson at digium.com
Thu Nov 13 17:39:03 CST 2008


Steve Murphy wrote:
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.digium.com/r/54/#review136
> -----------------------------------------------------------
> 
> 
> Mark, this was really good detective work.
> 
> I can see nothing wrong with what you did.
> 
> But I do see that I took the wrong turn a while back, and with fortitude, tried to make it work, but this
> and other problems are all saying to me: "You took
> the wrong path. Back out and try it a different way."
> 
> Trying to catch CDR data in the bridge looked good
> when I decided to try that way back when, but it's
> technically bankrupt, and your patch (and a few others
> I've made myself) pretty well prove it. But, this is
> a discussion for a different forum...
> 
> 
> 
> - Steve
> 
> 

Based on this, should I go ahead and commit the change to all the appropriate 
branches and just be prepared for it and a bunch of other changes to be reverted 
soon? Or were you trying to say not to even bother committing these changes 
since you would rather try to fix the problem of handling CDR's in the bridging 
code?

Mark Michelson



More information about the asterisk-dev mailing list