[asterisk-dev] [Code Review] Implement parsing of AGI XML documentation

[Russell Bryant]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.digium.com/r/50/#review125
-----------------------------------------------------------

Ship it!


Assuming it's tested (since that part wasn't filled in in the review request ;-) ), then it's good to go with these minor comments.



/trunk/include/asterisk/agi.h
<http://reviewboard.digium.com/r/50/#comment222>

    For what it's worth, I very much prefer the other style of doxygen documentation (not on the same line).
    
    My reasoning is that I think that having the docs on the same line encourages people to write very short, and often useless documentation.  It's much easier to write useful documentation that can span multiple lines when you put it before the var you are documenting.



/trunk/main/xmldoc.c
<http://reviewboard.digium.com/r/50/#comment223>

    if (!enumname) continue;  ;-)


- Russell


On 2008-11-11 07:17:56, Eliel Sardañons wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.digium.com/r/50/
> -----------------------------------------------------------
> 
> (Updated 2008-11-11 07:17:56)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> This is the implementation needed to parse the AGI XML documentation, the syntax generator was made with the idea of used it to parse the CLI syntax in the near future.
> 
> 
> Diffs
> -----
> 
>   /trunk/doc/appdocsxml.dtd 155928 
>   /trunk/include/asterisk/agi.h 155928 
>   /trunk/main/xmldoc.c 155928 
>   /trunk/res/res_agi.c 155928 
> 
> Diff: http://reviewboard.digium.com/r/50/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Eliel
> 
>