[asterisk-dev] [Code Review] Introduce CLI aliases and remove deprecated CLI commands because we now have aliases for them

[Russell Bryant]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.digium.com/r/32/#review120
-----------------------------------------------------------



trunk/res/res_clialiases.c
<http://reviewboard.digium.com/r/32/#comment211>

    change CMP_MATCH to CMP_MATCH | CMP_STOP



trunk/res/res_clialiases.c
<http://reviewboard.digium.com/r/32/#comment212>

    So, I think I told you to add CMP_STOP here, but then I also asked you to change the way ao2_callback() was run to destroy marked commands.  Basically, those two suggestions are not valid together.  I apologize.  Please take CMP_STOP back out of this one ...



trunk/res/res_clialiases.c
<http://reviewboard.digium.com/r/32/#comment213>

    Use ARRAY_LEN(cli_alias)


- Russell


On 2008-11-11 16:05:15, Michiel van Baak wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.digium.com/r/32/
> -----------------------------------------------------------
> 
> (Updated 2008-11-11 16:05:15)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> This patch introduces cli aliases.
> The config file holds a bunch of aliases for the deprecated commands in trunk so I could remove them from the code.
> 
> 
> Diffs
> -----
> 
>   trunk/channels/chan_mgcp.c 156009 
>   trunk/channels/chan_sip.c 156009 
>   trunk/channels/chan_skinny.c 156009 
>   trunk/configs/cli_aliases.conf.sample PRE-CREATION 
>   trunk/funcs/func_devstate.c 156009 
>   trunk/include/asterisk/cli.h 156009 
>   trunk/main/asterisk.c 156009 
>   trunk/main/cdr.c 156009 
>   trunk/main/cli.c 156009 
>   trunk/main/pbx.c 156009 
>   trunk/main/rtp.c 156009 
>   trunk/main/udptl.c 156009 
>   trunk/pbx/pbx_ael.c 156009 
>   trunk/pbx/pbx_dundi.c 156009 
>   trunk/res/res_agi.c 156009 
>   trunk/res/res_clialiases.c PRE-CREATION 
>   trunk/res/res_jabber.c 156009 
> 
> Diff: http://reviewboard.digium.com/r/32/diff
> 
> 
> Testing
> -------
> 
> compiles, installs and runs fine on my development laptop running OpenBSD 4.4
> 
> 
> Thanks,
> 
> Michiel
> 
>