[asterisk-dev] [Code Review] Introduce CLI aliases and remove deprecated CLI commands because we now have aliases for them

[Eliel Sardañons]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.digium.com/r/32/#review118
-----------------------------------------------------------



trunk/main/cli.c
<http://reviewboard.digium.com/r/32/#comment206>

    If you are modifying this documentation you could also put it in the right format (just a wish):
    
    /*! \internal
     *  \brief
     *  \param cmds
     *  \param match_type
     *  \retval 0
     *  \retval -1
     *  \retval 1
    */



trunk/main/cli.c
<http://reviewboard.digium.com/r/32/#comment207>

    You can replace this with S_OR(e->_full_cmd, e->command);



trunk/main/cli.c
<http://reviewboard.digium.com/r/32/#comment208>

    I think you can use: e->args instead of the magic '3'.


- Eliel


On 2008-11-11 15:09:00, Michiel van Baak wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.digium.com/r/32/
> -----------------------------------------------------------
> 
> (Updated 2008-11-11 15:09:00)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> This patch introduces cli aliases.
> The config file holds a bunch of aliases for the deprecated commands in trunk so I could remove them from the code.
> 
> 
> Diffs
> -----
> 
>   trunk/channels/chan_mgcp.c 156009 
>   trunk/channels/chan_sip.c 156009 
>   trunk/channels/chan_skinny.c 156009 
>   trunk/configs/cli_aliases.conf.sample PRE-CREATION 
>   trunk/funcs/func_devstate.c 156009 
>   trunk/include/asterisk/cli.h 156009 
>   trunk/main/asterisk.c 156009 
>   trunk/main/cdr.c 156009 
>   trunk/main/cli.c 156009 
>   trunk/main/pbx.c 156009 
>   trunk/main/rtp.c 156009 
>   trunk/main/udptl.c 156009 
>   trunk/pbx/pbx_ael.c 156009 
>   trunk/pbx/pbx_dundi.c 156009 
>   trunk/res/res_agi.c 156009 
>   trunk/res/res_clialiases.c PRE-CREATION 
>   trunk/res/res_jabber.c 156009 
> 
> Diff: http://reviewboard.digium.com/r/32/diff
> 
> 
> Testing
> -------
> 
> compiles, installs and runs fine on my development laptop running OpenBSD 4.4
> 
> 
> Thanks,
> 
> Michiel
> 
>