[asterisk-dev] [Code Review] AGI XML Documentation

Russell Bryant russell at digium.com
Sun Nov 9 09:32:22 CST 2008


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.digium.com/r/42/#review113
-----------------------------------------------------------



/trunk/include/asterisk/pbx.h
<http://reviewboard.digium.com/r/42/#comment204>

    I think that this stuff should all go in its own new C file and header file.  pbx.c/pbx.h is already pretty overloaded.


- Russell


On 2008-11-09 00:41:00, Eliel Sardañons wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.digium.com/r/42/
> -----------------------------------------------------------
> 
> (Updated 2008-11-09 00:41:00)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> With this patch we will be able to start moving the AGI documentation to XML. All the moved code of this patch was to export the xml documentation api, now named ast_xmldoc.
> And the cli command 'agi show commands' was changed to show the documentation as the applications and functions:
> -= Info about AGI '' =-
> [Synopsis]
> ...
> [Description]
> ...
> [Runs Dead]
> ....
> 
> Another modification was the xmldoc_colorization, to ast_xmldoc_printable() with a new parameter 'withcolors' so, we will be able to print the output with or without colors, this was needed for the cli command 'agi dump html'.
> 
> 
> Diffs
> -----
> 
>   /trunk/include/asterisk/agi.h 155555 
>   /trunk/include/asterisk/pbx.h 155555 
>   /trunk/main/pbx.c 155555 
>   /trunk/res/res_agi.c 155555 
> 
> Diff: http://reviewboard.digium.com/r/42/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Eliel
> 
>




More information about the asterisk-dev mailing list