[asterisk-dev] [Code Review] Introduce CLI aliases and remove deprecated CLI commands because we now have aliases for them

[Russell Bryant]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.digium.com/r/32/#review110
-----------------------------------------------------------



trunk/channels/chan_mgcp.c
<http://reviewboard.digium.com/r/32/#comment202>

    The actual CLI aliases module and config file have gone missing in this latest patch ..



trunk/include/asterisk/cli.h
<http://reviewboard.digium.com/r/32/#comment199>

    I think you said you removed this function.  If so, kill of this prototype, too.



trunk/main/cli.c
<http://reviewboard.digium.com/r/32/#comment200>

    Update this comment to say "core show help " instead of "help "



trunk/main/cli.c
<http://reviewboard.digium.com/r/32/#comment201>

    While you're changing this line anyway, formatting guidelines are that there are spaces around the "+"


- Russell


On 2008-11-07 10:47:53, Michiel van Baak wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.digium.com/r/32/
> -----------------------------------------------------------
> 
> (Updated 2008-11-07 10:47:53)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> This patch introduces cli aliases.
> The config file holds a bunch of aliases for the deprecated commands in trunk so I could remove them from the code.
> 
> 
> Diffs
> -----
> 
>   trunk/channels/chan_mgcp.c 155285 
>   trunk/channels/chan_sip.c 155285 
>   trunk/channels/chan_skinny.c 155285 
>   trunk/funcs/func_devstate.c 155285 
>   trunk/include/asterisk/cli.h 155285 
>   trunk/main/asterisk.c 155285 
>   trunk/main/cdr.c 155285 
>   trunk/main/cli.c 155285 
>   trunk/main/pbx.c 155285 
>   trunk/main/rtp.c 155285 
>   trunk/main/udptl.c 155285 
>   trunk/pbx/pbx_ael.c 155285 
>   trunk/pbx/pbx_dundi.c 155285 
>   trunk/res/res_agi.c 155285 
>   trunk/res/res_jabber.c 155285 
> 
> Diff: http://reviewboard.digium.com/r/32/diff
> 
> 
> Testing
> -------
> 
> compiles, installs and runs fine on my development laptop running OpenBSD 4.4
> 
> 
> Thanks,
> 
> Michiel
> 
>