[asterisk-dev] [Code Review] Convert open coded lists in indications to linked list macros

[Russell Bryant]

> On 2008-11-06 11:10:45, Russell Bryant wrote:
> > /trunk/main/indications.c, lines 556-559
> > <http://reviewboard.digium.com/r/34/diff/1/?file=1225#file1225line556>
> >
> >     The old code inserted the element at the head of the list, not the tail

Ignore this... I fail at reading code :)


> On 2008-11-06 11:10:45, Russell Bryant wrote:
> > /trunk/res/res_indications.c, lines 401-404
> > <http://reviewboard.digium.com/r/34/diff/1/?file=1226#file1226line401>
> >
> >     Again, you changed a head insert to a tail insert

Ignore this, too


- Russell


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.digium.com/r/34/#review83
-----------------------------------------------------------


On 2008-11-06 15:42:22, Sean Bright wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.digium.com/r/34/
> -----------------------------------------------------------
> 
> (Updated 2008-11-06 15:42:22)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> (I added this before but I guess I did something wrong when I published it)
> 
> This patch converts the open coded linked list in the indications code to use the AST_LIST_* macros.  Using the list macros is less error prone and reduces the amount of code needed to manage the structures.
> 
> But honestly, my main motivation for writing this was to bump up my C skills on ohloh.
> 
> 
> Diffs
> -----
> 
>   /trunk/include/asterisk/indications.h 155080 
>   /trunk/main/indications.c 155080 
>   /trunk/res/res_indications.c 155080 
> 
> Diff: http://reviewboard.digium.com/r/34/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sean
> 
>