[asterisk-dev] [Code Review] Introduce CLI aliases and remove deprecated CLI commands because we now have aliases for them

[Michiel van Baak]

> On 2008-11-05 16:49:48, Eliel Sardañons wrote:
> > trunk/res/res_clialiases.c, line 121
> > <http://reviewboard.digium.com/r/32/diff/1/?file=1197#file1197line121>
> >
> >     It is needed to alloc that much? we dont have a AST_MAX_ARGS?

in main/cli.c there is a cmd variable: cmd[512] so we need at least that. the AST_MAX_ARGS is 64 by default so not even close.


> On 2008-11-05 16:49:48, Eliel Sardañons wrote:
> > trunk/include/asterisk/cli.h, line 169
> > <http://reviewboard.digium.com/r/32/diff/1/?file=1187#file1187line169>
> >
> >     use /**/ instead of //

I'm removing that. I commented it out to test the new implementation, but it's not needed anymore.


> On 2008-11-05 16:49:48, Eliel Sardañons wrote:
> > trunk/res/res_clialiases.c, lines 212-231
> > <http://reviewboard.digium.com/r/32/diff/1/?file=1197#file1197line212>
> >
> >     indentation could be avoided with something like
> >     
> >     if (strcmp()) {
> >           ast_log();
> >           continue;
> >     }
> >     ....

fixing this one, thanks for the pointer


- Michiel


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.digium.com/r/32/#review77
-----------------------------------------------------------


On 2008-11-05 16:27:58, Michiel van Baak wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.digium.com/r/32/
> -----------------------------------------------------------
> 
> (Updated 2008-11-05 16:27:58)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> This patch introduces cli aliases.
> The config file holds a bunch of aliases for the deprecated commands in trunk so I could remove them from the code.
> 
> 
> Diffs
> -----
> 
>   trunk/channels/chan_mgcp.c 154877 
>   trunk/channels/chan_sip.c 154877 
>   trunk/channels/chan_skinny.c 154877 
>   trunk/configs/cli_aliases.conf.sample PRE-CREATION 
>   trunk/funcs/func_devstate.c 154877 
>   trunk/include/asterisk/cli.h 154877 
>   trunk/main/asterisk.c 154877 
>   trunk/main/cdr.c 154877 
>   trunk/main/cli.c 154877 
>   trunk/main/pbx.c 154877 
>   trunk/main/rtp.c 154877 
>   trunk/main/udptl.c 154877 
>   trunk/pbx/pbx_ael.c 154877 
>   trunk/pbx/pbx_dundi.c 154877 
>   trunk/res/res_agi.c 154877 
>   trunk/res/res_clialiases.c PRE-CREATION 
>   trunk/res/res_jabber.c 154877 
> 
> Diff: http://reviewboard.digium.com/r/32/diff
> 
> 
> Testing
> -------
> 
> compiles, installs and runs fine on my development laptop running OpenBSD 4.4
> 
> 
> Thanks,
> 
> Michiel
> 
>