[asterisk-dev] [Code Review] appdocsxml install structure for asterisk-addons

[Russell Bryant]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.digium.com/r/26/#review74
-----------------------------------------------------------



/trunk/Makefile
<http://reviewboard.digium.com/r/26/#comment129>

    This is ok for now, but I would like to think about putting all of this logic out into a script.  With this in addons, we have two copies of this exact logic.  If we put it into a script in the build_tools directory, it will at least be easier to keep the ones in asterisk and -addons in sync.
    
    (Some day, we'll actually have both Asterisk and -Addons share a build_tools directory, so staying in sync will be automatic.)



/trunk/doc/appdocsxml.dtd
<http://reviewboard.digium.com/r/26/#comment128>

    I'm concerned with having two copies of this DTD.  How about we have the main Asterisk source install this file with the documentation.  Then, when we do validation from here, we use the installed copy.


- Russell


On 2008-11-04 14:05:23, Eliel Sardañons wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.digium.com/r/26/
> -----------------------------------------------------------
> 
> (Updated 2008-11-04 14:05:23)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Structure of the make process for appdocsxml in asterisk-addons.
> 
> 
> Diffs
> -----
> 
>   /trunk/Makefile 684 
>   /trunk/build_tools/get_documentation PRE-CREATION 
>   /trunk/configure 684 
>   /trunk/configure.ac 684 
>   /trunk/doc/appdocsxml.dtd PRE-CREATION 
>   /trunk/makeopts.in 684 
> 
> Diff: http://reviewboard.digium.com/r/26/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Eliel
> 
>