[asterisk-dev] Time for a bug fix phase?

[Russell Bryant]

Steve Davies wrote:
> Ref: Bug#10052, BLF/Line status seems to be fixed for those that have
> tried using the attached "notify.1_4_12.patch". This is a truly
> trivial patch, which seems to solve a logic flaw (probably a typo from
> long ago) which allows a list of outstanding NOTIFY packets to be
> collected, but then never used.
> 
> The patch should port to 1.6.x very easily. I am using the 1.2.x
> version of this patch on at least 30 sites now, and have seen no
> problems.
> 
> OEJ seems to be proposing a larger fix which rationalises NOTIFY
> transmissions, which is probably a "Very Good Thing(tm)", but IMHO
> does not reduce the need to apply "notify.1_4_12.patch" to fix the
> underlying problem.

IIRC, the attached patch is very much not correct, and that is why it has not 
been committed.  Just because it is one line, doesn't mean it is safe or 
correct.  :)  Anyway, we should look again to be sure ...

I looked at this issue with oej, and we identified clear issues with NOTIFY 
handling in the case where the relevant hint has multiple devices associated 
with it.  We discussed ways to fix it, and he indicated that he wanted to work 
on the fix.  Since he wanted to do it, I haven't touched it, since.

However, in case someone else wants to look at it, I will try to spend some time 
writing down the details of what needs to be addressed.

-- 
Russell Bryant
Senior Software Engineer
Open Source Team Lead
Digium, Inc.