[asterisk-dev] Voicemail with 's' option isn't really silent

[Michiel van Baak]

On 16:58, Thu 13 Mar 08, Horwich IT Services wrote:
> No takers for this?

since it's not really a bug (you can question that, I know)
I think you have more luck when you post a patch against
trunk on bugs.digium.com
> 
> On Tue, 11 Mar 2008 19:44:43 +0000, Horwich IT Services (Godwin Stewart)
> <g.stewart at horwits.co.uk> wrote:
> 
> > Hi,
> > 
> > While trying to silence the Voicemail application completely -- ie: do
> > away not only with the instructions given before the beep but also the
> > 'thank you' message played back after the caller presses the '#' key, I
> > started looking at the code of Asterisk 1.4.10 and now 1.4.18.
> > 
> > In apps/app_voicemail.c, I see that the 'silent' flag is parsed by
> > vm_exec() and then passed along to leave_voicemail().
> > 
> > leave_voicemail(), however, does not pass this flag along to
> > play_record_review(), so by the time execution reaches
> > ast_play_and_record_full() and then __ast_play_and_record() in main/app.c,
> > the 'silent' flag has long since been lost and the 'auth-thankyou' sound
> > is played back regardless.
> > 
> > I can see the point in playing back the beep in all cases, but is there a
> > compelling reason why 'auth-thankyou' is played back anyway?
> > 
> > If I were to propose a patch against Asterisk 1.4.18 that passed the
> > 'silent' flag *all* the way down the call stack, thus making the various
> > applications that call __ast_play_and_record() actually do "what it says
> > on the tin", would there be any interest in it or am I alone on a crusade
> > here?
> > 
> > Alternatively, should it not be the application ultimately calling
> > __ast_play_and_record() that takes responsibility for playing back
> > 'auth-thankyou'? This approach certainly seems more logical to me in that
> > it negates the need to modify function prototypes.
> > 
> > Any thoughts?
> 
> -- 
> Godwin Stewart - Horwich IT services
> 
> _______________________________________________
> --Bandwidth and Colocation Provided by http://www.api-digital.com--
> 
> asterisk-dev mailing list
> To UNSUBSCRIBE or update options visit:
>    http://lists.digium.com/mailman/listinfo/asterisk-dev

-- 

Michiel van Baak
michiel at vanbaak.eu
http://michiel.vanbaak.eu
GnuPG key: http://pgp.mit.edu:11371/pks/lookup?op=get&search=0x71C946BD

"Why is it drug addicts and computer aficionados are both called users?"