[asterisk-dev] qwell: branch 1.4 r125587 - /branches/1.4/main/utils.c

[Russell Bryant]

On Jun 26, 2008, at 7:03 PM, SVN commits to the Digium repositories  
wrote:

> Author: qwell
> Date: Thu Jun 26 18:03:15 2008
> New Revision: 125587
>
> URL: http://svn.digium.com/view/asterisk?view=rev&rev=125587
> Log:
> Make sure to unlock the lock_info lock (huh?).  Possible deadlock?
>
> Modified:
>    branches/1.4/main/utils.c
>
> Modified: branches/1.4/main/utils.c
> URL: http://svn.digium.com/view/asterisk/branches/1.4/main/utils.c?view=diff&rev=125587&r1=125586&r2=125587
> = 
> = 
> = 
> = 
> = 
> = 
> = 
> = 
> ======================================================================
> --- branches/1.4/main/utils.c (original)
> +++ branches/1.4/main/utils.c Thu Jun 26 18:03:15 2008
> @@ -701,6 +701,9 @@
> 	*lineno = lock_info->locks[i].line_num;
> 	*func = lock_info->locks[i].func;
> 	*mutex_name = lock_info->locks[i].lock_name;
> +
> +	pthread_mutex_unlock(&lock_info->lock);
> +
> 	return 0;
> }


Even though it only affects DEBUG_THREADS, this is still quite bad, as  
it makes that debugging mode pretty useless.  Have you looked to see  
when this got lost?  Is it gone in the latest release?

--
Russell Bryant
Senior Software Engineer
Open Source Team Lead
Digium, Inc.