[asterisk-dev] tilghman: trunk r123648 - /trunk/apps/app_dial.c

[Tilghman Lesher]

On Wednesday 18 June 2008 11:57:47 Russell Bryant wrote:
> Tilghman Lesher wrote:
> > I thought this janitor was a technicality.  While it hasn't presented any
> > problems to date, it was technically a race, and so we opted to make
> > these changes only in trunk.  If I am incorrect, I will backport the
> > patch.
>
> Oh, I guess you're right.  I knew the ast_change_name() API call existed
> in Asterisk 1.4, but it's not used anywhere in the code.
>
> However, there is at least one place that I can think of where the name
> of the channel changes that could potentially exploit this race
> condition.  That is in ast_do_masquerade, when <ZOMBIE> gets appended to
> the channel name.

I'm not sure why that would make a difference here.  This changeset was all
about channel variables, which is not where the channel name is stored.

-- 
Tilghman