[asterisk-dev] oej: trunk r128240 - in /trunk: include/asterisk/ main/ pbx/ res/

Russell Bryant russell at digium.com
Sat Jul 5 23:11:02 CDT 2008


On Jul 5, 2008, at 4:54 PM, SVN commits to the Digium repositories  
wrote:

> Author: oej
> Date: Sat Jul  5 15:54:30 2008
> New Revision: 128240
>
> URL: http://svn.digium.com/view/asterisk?view=rev&rev=128240
> Log:
> Implement flags for AGI in the channel structure so taht "show  
> channels" and
> AMI commands can display that a channel is under control of an AGI.
>
> Work inspired by work at customer site, but paid for by Edvina AB

To be honest, I do not think this is something that should be merged  
in to Asterisk.  It doesn't seem generally applicable enough.  Also,  
I'm not especially pleased with the implementation, either.

I don't like that it uses _3_ channel flags.  Also, you added a public  
API call without a proper ast_ prefix.

Anyway, unless others find this generally useful enough, I'd like to  
exercise my veto.  :)

--
Russell Bryant
Senior Software Engineer
Open Source Team Lead
Digium, Inc.







More information about the asterisk-dev mailing list