[asterisk-dev] Coding guidelines change (proposed)

Paul Hewlett paul at gccs.co.za
Wed Feb 27 01:26:41 CST 2008


BJ Weschke wrote:
>  +1
>
> Tilghman Lesher wrote:
>   
>> I'd like to propose a change to the coding guidelines, and I'm airing it here
>> for specific feedback before we make this change.  Currently, our standard
>> is that if you have a single statement following an if/for/while construct,
>> then we do not require parentheses around the single statement.  While this
>> is legal C, it has caused a number of issues in the past, where another
>> statement was added at that indentation level, but without adding the
>> necessary braces.
>>
>> I'd like to change the coding guidelines that the braces are no longer
>> optional; that they are mandatory, and if this change is approved, a janitor
>> project will be posted shortly to convert legacy code to the new standard.
>>
>> Are there any comments or objections before we implement this change?
>>
>>   
>>     
>
>
>   
What about coming up with a standard 'indent'
 command that will format the code to Digium's requirements ?
Add this as a rule in the Makefile

Each developer can then code in whatever style he likes.  When finished 
and before making patches execute 'make indent' and you are done.


Paul

-- 
Technical Director, GCCS
Tel: 086 111 3433 Fax: 086 111 3520 Cel: 076 072 7906
web: http://www.gccs.co.za




More information about the asterisk-dev mailing list