[asterisk-dev] [svn-commits] file: trunk r103799 - in /trunk: channels/ include/asterisk/ main/

[Russell Bryant]

SVN commits to the Digium repositories wrote:
> Author: file
> Date: Mon Feb 18 17:47:01 2008
> New Revision: 103799
> 
> URL: http://svn.digium.com/view/asterisk?view=rev&rev=103799
> Log:
> Add a non-invasive API for application level manipulation of T38 on a channel. This uses control frames (so they can even pass across IAX2) to negotiate T38 and provided a way of getting the current status of T38 using queryoption. This should by no means cause any issues and if it does I will take responsibility for it.
> (closes issue #11873)
> Reported by: dimas
> Patches:
>       v4-t38-api.patch uploaded by dimas (license 88)

You mention that these frames can pass across IAX2.  That is true, except there
is a minor issue with it.  Since the payload of these frames is an integer, you
have to make sure that byte order gets handled.  chan_iax2 already has some code
to handle byte swapping when the frame has a payload with 2 byte audio samples
(signed linear).  So, I would add similar code for when it's a T38 control frame.

-- 
Russell Bryant
Senior Software Engineer
Open Source Team Lead
Digium, Inc.