[asterisk-dev] [svn-commits] mvanbaak: branch mvanbaak/cli-command-audit r101579 - in /team/mvanbaak/cli-c...

[Michiel van Baak]

On 22:36, Thu 31 Jan 08, Russell Bryant wrote:
> SVN commits to the Digium repositories wrote:
> > Author: mvanbaak
> > Date: Thu Jan 31 16:05:44 2008
> > New Revision: 101579
> > 
> > URL: http://svn.digium.com/view/asterisk?view=rev&rev=101579
> > Log:
> > add patches from mantis to this branch
> 
> > -	if (a->argc != 2)
> > +	if (a->argc != 3)
> >  		return CLI_SHOWUSAGE;
> 
> You have this type of change in a bunch of places.  Instead of changing
> it that way, a better thing to do is to change it to:
> 
> if (a->argc != e->args)
> 
> That way, no matter how many words make up the CLI command, you won't
> have to change it again.

Ok, fixed in main/asterisk.c and I'll keep in mind in all
the other places we are going to do this.
-- 

Michiel van Baak
michiel at vanbaak.eu
http://michiel.vanbaak.eu
GnuPG key: http://pgp.mit.edu:11371/pks/lookup?op=get&search=0x71C946BD

"Why is it drug addicts and computer aficionados are both called users?"