[asterisk-dev] [Code Review] Bridging API for Conference Bridge purposes

[Joshua Colp]

> On 2008-12-16 07:59:58, Russell Bryant wrote:
> > /trunk/bridges/bridge_multiplexed.c, lines 57-60
> > <http://reviewboard.digium.com/r/93/diff/1/?file=1912#file1912line57>
> >
> >     I presume these should just be unsigned.

Indeed.


> On 2008-12-16 07:59:58, Russell Bryant wrote:
> > /trunk/bridges/bridge_multiplexed.c, line 148
> > <http://reviewboard.digium.com/r/93/diff/1/?file=1912#file1912line148>
> >
> >     You can remove attribute_unused

Done. Silly leftover code from development.


> On 2008-12-16 07:59:58, Russell Bryant wrote:
> > /trunk/bridges/bridge_multiplexed.c, line 284
> > <http://reviewboard.digium.com/r/93/diff/1/?file=1912#file1912line284>
> >
> >     Now that you have bridge_multiplexed, should this one be set to MEDIUM?

I have lowered bridge_simple down to medium.


> On 2008-12-16 07:59:58, Russell Bryant wrote:
> > /trunk/bridges/bridge_softmix.c, lines 105-106
> > <http://reviewboard.digium.com/r/93/diff/1/?file=1914#file1914line105>
> >
> >     It looks like either the define is misnamed, or it's being misused here

Done.


- Joshua


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.digium.com/r/93/#review231
-----------------------------------------------------------


On 2008-12-16 07:44:19, Joshua Colp wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.digium.com/r/93/
> -----------------------------------------------------------
> 
> (Updated 2008-12-16 07:44:19)
> 
> 
> Review request for Asterisk Developers and Russell Bryant.
> 
> 
> Summary
> -------
> 
> This patch implements the new bridging API and brings with it a module for conference bridges. It does *not* replace existing internal bridging or features yet and will not cause any regressions when put in. It will essentially be introduced as a first test phase to work out any unforeseen critical issues. The bridging core itself is fully implemented besides the following: jitterbuffer support, native bridging, and interval hooks (hooks that are time based versus action based). If you would like an explanation of what the bridging API is made up of and how it works that can be found in the bridging.h header file.
> 
> 
> Diffs
> -----
> 
>   /trunk/Makefile 164597 
>   /trunk/apps/app_confbridge.c PRE-CREATION 
>   /trunk/bridges/Makefile PRE-CREATION 
>   /trunk/bridges/bridge_multiplexed.c PRE-CREATION 
>   /trunk/bridges/bridge_simple.c PRE-CREATION 
>   /trunk/bridges/bridge_softmix.c PRE-CREATION 
>   /trunk/channels/chan_bridge.c PRE-CREATION 
>   /trunk/include/asterisk/bridging.h PRE-CREATION 
>   /trunk/include/asterisk/channel.h 164597 
>   /trunk/main/Makefile 164597 
>   /trunk/main/bridging.c PRE-CREATION 
> 
> Diff: http://reviewboard.digium.com/r/93/diff
> 
> 
> Testing
> -------
> 
> Conference bridge testing using app_confbridge with features. Joining two channels with simple frame exchange and joining three channels to move it to a true conference bridge. IVR capability of app_confbridge was also tested.
> 
> 
> Thanks,
> 
> Joshua
> 
>